Skip to content

Change to use isOffheapAllocationEnabled query #19926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

zl-wang
Copy link
Contributor

@zl-wang zl-wang commented Jul 26, 2024

wherever it is appropriate (and intended), isIndexableDataAddrPresent is changed into isOffheapAllocationEnabled.

wherever it is appropriate (and intended), isIndexableDataAddrPresent is changed into isOffheapAllocationEnabled.

Signed-off-by: Julian <[email protected]>
@zl-wang zl-wang requested a review from dsouzai as a code owner July 26, 2024 20:53
@zl-wang zl-wang requested review from r30shah and removed request for dsouzai July 26, 2024 20:55
Copy link
Contributor

@r30shah r30shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@r30shah
Copy link
Contributor

r30shah commented Jul 26, 2024

jenkins test sanity all jdk21

@zl-wang
Copy link
Contributor Author

zl-wang commented Jul 29, 2024

windows build/test was aborted due to infrastructure issue. we observed the same in other PRs.

@r30shah
Copy link
Contributor

r30shah commented Jul 29, 2024

Yes, windows system seems offline [1]. Merging this change as test has passed on all other platforms.

[1]. https://openj9-jenkins.osuosl.org/label/ci.role.build&&hw.arch.x86&&sw.os.windows/

@r30shah r30shah merged commit c5b3b09 into eclipse-openj9:master Jul 29, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants