Adds FSD check to jitClassRedefineEvent #19949
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jitClassRedefineEvent is updated to include an explicit check for FSD being enabled. The result of this is the code cache is tossed out if either HCR extensions are enabled or FSD mode is enabled. Signed-off-by: jimmyk <[email protected]>
|
@jdmpapin This might be of interest to you. |
|
I think this needs a VM reviewer. The change is in VM code, and I was also involved before the PR was opened. @tajila, could you please review or suggest a reviewer? |
gacholio
approved these changes
Aug 1, 2024
|
jenkins test sanity zlinux jdk21 |
|
I suspect that checking FSD enabled is sufficient, since FSD enabled implied extensions are enabled until the recent change to disable extensions by default (which no doubt introduced the problem this is fixing). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jitClassRedefineEvent is updated to include an explicit check for FSD being enabled.
The result of this is the code cache is tossed out if either HCR extensions are enabled or FSD mode is enabled.
Issue: #19813