JFR Writer fixes part1 #19969
Merged
JFR Writer fixes part1 #19969
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gacholio please review these changes |
gacholio
reviewed
Aug 6, 2024
|
No particular code in mind, but is there going to be any confusion between constant strings and allocated ones? |
|
String entries have a |
gacholio
reviewed
Aug 7, 2024
|
This looks fine. I won't insist on the += changes if you prefer things this way. |
- Add default entries for empty stack traces and unknown native methods. - Add missing free for stackframe entries after writing chunk. - Iterate the stack trace one before to get the real size. - JFR readers do not accepts UDATA_MAX values for BCI and line numers, so use 0 instead if values are unknown. - Add support for writing intermediate jfr files, currently we use this for debugging. But there are JFR modes that require this. - Add compressedInts flag to chunk writer. There is more work to be done for handling internal native functions as well as fixing the timestamps this will be addressed in a future PR. Signed-off-by: Tobi Ajila <[email protected]>
gacholio
approved these changes
Aug 8, 2024
|
jenkins test sanity xlinux jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is more work to be done for handling internal native functions as well as fixing the timestamps this will be addressed in a future PR.