Don't make upcall helper methods static on Z #19982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is still pending some internal builds passing. Opening it here so that we can start with review and external testing in parallel. I will update here once my internal builds pass. |
Static functions outside of a class must be declared in files where they are used. This commit fixes this. Signed-off-by: Dhruv Chopra <[email protected]>
|
jenkins test sanity zlinux jdk21,jdk8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making FFI Upcall's helper methods static causes compilation failures on certain platforms and build levels as the compiler expects the methods to be used internally. This commit removes that requirement.