Skip to content

[FFI] Restore the original check on argument values on the java stack #19998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ChengJin01
Copy link

@ChengJin01 ChengJin01 commented Aug 14, 2024

The changes restore the original check on argument values
in #19649 with slight modifications to ensure it achieves
the same functionalities without sacrificing the performance
due to the restriction of compiler on Windows.

Fixes: Internal 454

Signed-off-by: ChengJin01 [email protected]

The changes restore the original check on argument values
in eclipse-openj9#19649 with slight modifications to ensure it achieve
the same functionalities without sacrificing the performance
due to the restriction of compiler on Windows.

Fixes: [Internal
454](https://github.ibm.com/runtimes/javanext/issues/454)

Signed-off-by: ChengJin01 <[email protected]>
@ChengJin01
Copy link
Author

ChengJin01 commented Aug 14, 2024

The PR has been verified in personal builds (JDK17+) on all support platforms.

@ChengJin01 ChengJin01 added comp:vm project:panama Used to track Project Panama related work labels Aug 14, 2024
@ChengJin01
Copy link
Author

ChengJin01 commented Aug 14, 2024

Reviewer: @pshipton
FYI: @tajila, @gacholio

@ChengJin01 ChengJin01 requested a review from pshipton August 14, 2024 14:06
@pshipton pshipton merged commit 1a6a7d2 into eclipse-openj9:master Aug 15, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:vm project:panama Used to track Project Panama related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants