Fix array and memory segment access in VectorAPIExpansion #20553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gita-omr
commented
Nov 8, 2024
gita-omr
commented
- we should not add array header to the address but use base address and offset provided by the intrinsic, whether it's array or segment
gita-omr
added this to the
Release 0.49 (Java 8, 11, 17, 21, 23) January refresh milestone
0xdaryl
reviewed
Nov 13, 2024
| @@ -1267,6 +1267,13 @@ TR_VectorAPIExpansion::generateAddressNode(TR::Compilation *comp, TR::Node *arra | |||
| return aladdNode; | |||
| } | |||
|
|
|||
| TR::Node * | |||
| TR_VectorAPIExpansion::generateAddressNode(TR::Compilation *comp, TR::Node *base, TR::Node *offset) | |||
There was a problem hiding this comment.
The compilation object is not used in this function. Does it need to be part of the API?
There was a problem hiding this comment.
Right. I will remove it.
|
Jenkins test sanity all jdk21 |
|
jdk_utik_0 failure on Z seems to be unrelated. |
|
Please squash commits and we can merge. |
- we should not add array header to the address but use base address and offset provided by the intrinsic, whether it's array or segment
|
Squashed. Thanks! |
0xdaryl
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.