Skip to content

Fix unnamed module spelling mistake #20603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

ThanHenderson
Copy link
Contributor

Signed-off-by: Nathan Henderson [email protected]

@babsingh
Copy link
Contributor

jenkins test sanity.functional amac jdk21

@ThanHenderson
Copy link
Contributor Author

ThanHenderson commented Nov 15, 2024

@babsingh I've also opened: eclipse-omr/omr#7546

There may need coordination/special handling.

Alternatively, I could just remove the change here to the OMR_GLUE function in this PR, since what I really care about is unnamedModuleForSystemLoader; I had just figured I'd address the OMR_GLUE typo as well.

We could address the OMR_GLUE one separately.

@babsingh
Copy link
Contributor

babsingh commented Nov 15, 2024

It should be fine. I will merge both together so that the omr promotion builds pick up the OpenJ9 changes. A new PR for the coordinated change should be fine.

@babsingh
Copy link
Contributor

jenkins test sanity.functional amac jdk21

@ThanHenderson ThanHenderson changed the title Fix unnamed spelling mistake Fix unnamed module spelling mistake Nov 15, 2024
@babsingh babsingh merged commit 0b18eb2 into eclipse-openj9:master Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants