(0.49.0) Change J9::VMMethodEnv::startPC error return value #20720
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OMR version of startPC expects either a valid start PC or 0 to be returned from J9::VMMethodEnv::startPC since it isn't aware of the J9 specific non-startPC special values that are currently being returned. This change checks if the J9_STARTPC_NOT_TRANSLATED bit flag is set on the startPC to be returned. This indicates that it isn't a real startPC and will return 0 instead. Error checking has also been added to addFreeBlock to handle startPC returning 0. Signed-off-by: jimmyk <[email protected]>
pshipton
added this to the
Release 0.49 (Java 8, 11, 17, 21, 23) January refresh milestone
pshipton
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OMR version of startPC expects either a valid start PC or 0 to be returned from J9::VMMethodEnv::startPC since it isn't aware of the J9 specific non-startPC special values that are currently being returned.
This change checks if the J9_STARTPC_NOT_TRANSLATED bit flag is set on the startPC to be returned. This indicates that it isn't a real startPC and will return 0 instead.
Error checking has also been added to addFreeBlock to handle startPC returning 0.
Backport of #20657