0.51: Fix bug in TR_IPBCDataFourBytes::getSumBranchCount #21280
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TR_IPBCDataFourBytes::getSumBranchCount returns the sum of the two branch counters. Internally these are stored as two 16 bit integers. getSumBranchCount is called only by TR_IProfiler::getSamplingCount which returns a int32_t. However, TR_IPBCDataFourBytes::getSumBranchCount sums up the two 16 bit integers as uint16_ts and returns a int16_t. This has the consequence of sometimes returning a negative number because of overflow. This commit fixes this by consistently using int32_t. Signed-off-by: Irwin D'Souza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #21274