(v0.51.0) Support JEP491 in VM code path #21308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update Continuation.Pinned enum Add field refs in vmconstantpool.xml add helper to update monitor info add enterObjectMonitor intercept Add support for Object.wait/notify() Add reverse link between J9VMContinuation and vthread & remove Object ref in J9ObjectMonitor Move JVM_TakeVirtualThreadListToUnblock code into helper Rename XX:YieldPinnedContinuation to XX:YieldPinnedVirtualThreads Co-authored-by: Jack Lu <[email protected]> Co-authored-by: Babneet Singh <[email protected]> Co-authored-by: Keith W. Campbell <[email protected]>
Move enter/exitVThreadTransitionCritical to ContinuationHelpers.hpp Enter critical before yielding a pinned vthread Exit critical after vthread re-entry from a pinned state (not vthread.yield) Co-authored-by: Babneet Singh <[email protected]> Co-authored-by: Jack Lu <[email protected]>
Correctly handle the waiting object during detach/attach. Use vthread.notified field to indicate status. Prevent vthreads in transition to be returned as unblocked. Co-authored-by: Babneet Singh <[email protected]> Signed-off-by: Jack Lu <[email protected]>
Update isPinnedImpl to ignore ownedMonitorCount when trying to yield. Handle the detach/attach when yielding vthread holds monitors. Signed-off-by: Jack Lu <[email protected]>
|
#21292 was merged yesterday. We should wait for tonight's nightly builds to pass before backporting these changes to the 0.51 release. If any issues arise, we will need to revert changes in two places. |
babsingh
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pack port of #21273 and #21292