(0.51) Enable peeking ILGen for inlined methods related to java/util/HashMap get/put operations #21309
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nazim Bhuiyan <[email protected]>
To propagate arg info from callers of HashMap.put, HashMap.get, and Object.hashCode, generating IL of their callers is necessary when called from an inlined method. This allows us to propagate prex arg info from caller and enable compile-time folding of fastIdentityHashCode calls. Signed-off-by: Nazim Bhuiyan <[email protected]>
For some call targets and their sub call graphs, it may be possible to simplify them into simple operations in certain situations, such as when known object info is being passed as arg. In such cases, the node count obtained via generateNodeEstimate would not truly reflect the number of nodes that are actually introduced. This commit adds a mechanism that terminates recursive call target walk during node count estimation when faced with call graphs that can be simplified into simple operations. Signed-off-by: Nazim Bhuiyan <[email protected]>
This routine was only being used for recursively walking call targets and counting nodes, despite being designed to perform any "action". It was not going to work for any action other than generateNodeEstimate as the debugTrace message relied on calling generateNodeEstimate::getNodeEstimate. This commit repurposes this function to only be used for node counting, rather than any "action", and renames the function accordingly. Signed-off-by: Nazim Bhuiyan <[email protected]>
|
@vijaysun-omr FYI |
vijaysun-omr
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes #21157 for 0.51.