Skip to content

(0.51) Implement JVM_GetProperties for jdk17+ #21349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

pshipton
Copy link
Member

This reverts commit f12ef36, which re-instates commit 9620a5a, PR #21200 plus some additional cosmetic changes, and the following.

Setting SystemProps.customTmpdir is unnecessary, and fails. It already has the correct value from calling
SystemProps.initProperties().

Issue #21311

Modify the tracepoint used by test to match VM changes. cmdLineTester_PageAlignDirectMemory uses the j9jcl.352 tracepoint, which has moved to j9vm.791.

Issue #21314

Update JVM_GetTemporaryDirectory

Fixes #21294

Related to #21189

Cherry pick #21320

This reverts commit f12ef36, which
re-instates commit 9620a5a, PR
eclipse-openj9#21200 plus some additional
cosmetic changes, and the following.

Setting SystemProps.customTmpdir is unnecessary, and fails.
It already has the correct value from calling
SystemProps.initProperties().

Issue eclipse-openj9#21311

Modify the tracepoint used by test to match VM changes.
cmdLineTester_PageAlignDirectMemory uses the j9jcl.352 tracepoint, which
has moved to j9vm.791.

Issue eclipse-openj9#21314

Update JVM_GetTemporaryDirectory

Signed-off-by: Peter Shipton <[email protected]>
@keithc-ca keithc-ca merged commit 556ddc6 into eclipse-openj9:v0.51.0-release Mar 13, 2025
2 checks passed
@JasonFengJ9
Copy link
Member

openjdk24_j9_sanity.openjdk_aarch64_linux

openjdk version "24" 2025-03-18
IBM Semeru Runtime Open Edition 24.0-m1 (build 24+36)
Eclipse OpenJ9 VM 24.0-m1 (build v0.51.0-release-70f26c921d, JRE 24 Linux aarch64-64-Bit Compressed References 20250318_16 (JIT enabled, AOT enabled)
OpenJ9   - 70f26c921d
OMR      - 20241356e
JCL      - c8ca8c74788 based on jdk-24+36)

[2025-03-17T17:49:23.196Z] actual vs expected[ 44]: 0xfffd != 0x003f
[2025-03-17T17:49:23.196Z] test ReaderWriterTest.testCaseNativeEncoding(): failure
[2025-03-17T17:49:23.196Z] java.lang.StringIndexOutOfBoundsException: Index 84 out of bounds for length 76

Java 24 milestone 1 build doesn't have this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants