(0.51) Virtual Threads: Bug fixes for JEP491 #21350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A null object monitor is being passed to detachMonitorInfo, which leads to a segfault. In the inflated case, the object monitor is correctly derived to prevent the segfault. This fix helps the LotsOfContendedMonitorEnter test in eclipse-openj9#20705. Signed-off-by: Babneet Singh <[email protected]>
If a notify is issued before wait, then there waitingContinuations will be NULL. In this case, the notify steps should not be executed since there are no virtual threads waiting, and waitingContinuations->vthread will be NULL. Addresses point 3 in the below Github comment: eclipse-openj9#20369 (comment). Signed-off-by: Babneet Singh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly derive an inflated object monitor
A null object monitor is being passed to
detachMonitorInfo, whichleads to a segfault. In the inflated case, the object monitor is
correctly derived to prevent the segfault.
This fix helps the
LotsOfContendedMonitorEntertest in #20705.Correctly handle notify before wait for virtual threads
If a notify is issued before wait, then there
waitingContinuationswill be
NULL. In this case, the notify steps should not be executedsince there are no virtual threads waiting, and
waitingContinuations->vthreadwill be NULL.Addresses point 3 in the below Github comment:
#20369 (comment).
Port of #21342.
Signed-off-by: Babneet Singh [email protected]