(0.51) Prevent callers of big callees getting marked as big during ECS #21383
+12
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mpirvu Requesting review and merge. |
|
I verified that the code is exactly the same as in the original commit. |
mpirvu
approved these changes
Mar 18, 2025
During Estimate Code Size, if we came across a callee that exceeded the bigCalleeThreshold, we would mark every method up the call chain as also having exceeded the bigCalleeThreshold. This resulted in removal of call targets above the callee marked as such. To get around this issue, we utilize the new field _bigCalleesSize that is set when a callee exceeds the bigCalleeThreshold, and is used to adjust the analyzed size of the methods above the big callee's level in the call chain to prevent them from getting marked as too big. Co-authored-by: Vijay Sundaresan <[email protected]> Signed-off-by: Nazim Bhuiyan <[email protected]>
This workaround is intended to prevent a functional issue with OpenJ9 MethodHanldes exposed by the ECS heuristics intended to account for callees marked as too big from marking methods up the call chain as also too big. Signed-off-by: Nazim Bhuiyan <[email protected]>
nbhuiyan
force-pushed
the
bigcallees-0.51
branch
from
a8ce51c to
7de1517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR delivers the changes in
#21364#21465 for 0.51.