Skip to content

Use cg flags to check compress/expand support #21795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Spencer-Comin
Copy link
Contributor

Use the codegen flags instead of cpu flags to check support for bitwise compress and expand IL opcodes when inlining (Integer|Long).(compress|expand).

Requires coordinated merge with eclipse-omr/omr#7740.

Use the flags from the CodeGenerator object instead of the CPU object
to check support for bitwise compress and expand IL opcodes when
inlining the Integer and Long compress and expand intrinsic methods.

Signed-off-by: Spencer Comin <[email protected]>
Copy link
Contributor

@r30shah r30shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hzongaro hzongaro self-assigned this May 20, 2025
Copy link
Member

@hzongaro hzongaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@hzongaro
Copy link
Member

Jenkins test sanity.functional,sanity.openjdk all jdk17,jdk21 depends eclipse-omr/omr#7740

@hzongaro
Copy link
Member

JDK 17 aarch64 mac build failure is unrelated to this change. Rerunning.

Jenkins test sanity.functional,sanity.openjdk amac jdk17 depends eclipse-omr/omr#7740

@hzongaro hzongaro added comp:jit depends:omr:breaking depends:omr Pull request is dependent on a corresponding change in OMR and removed depends:omr:breaking labels May 21, 2025
@hzongaro
Copy link
Member

As this will require a coordinated merge, I will add the testing of JDKs 8 and 11.

Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11 depends eclipse-omr/omr#7740

@hzongaro
Copy link
Member

JDK 11 AIX sanity.functional test failure does not appear to be something that could be related to this change.

@hzongaro
Copy link
Member

Test results look good. Only failure appears to be unrelated to this change. I will wait until the contents of https://github.com/eclipse-openj9/openj9-omr/tree/openj9, https://github.com/eclipse-openj9/openj9-omr/tree/master and https://github.com/eclipse-omr/omr/tree/master are consistent before performing the coordinated merge.

@hzongaro
Copy link
Member

Testing was successful. OMR Pull Request #7740 has been merged and promoted. Merging.

@hzongaro hzongaro merged commit 9674039 into eclipse-openj9:master May 23, 2025
97 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:jit depends:omr Pull request is dependent on a corresponding change in OMR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants