-
Notifications
You must be signed in to change notification settings - Fork 767
Use cg flags to check compress/expand support #21795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use cg flags to check compress/expand support #21795
Conversation
Use the flags from the CodeGenerator object instead of the CPU object to check support for bitwise compress and expand IL opcodes when inlining the Integer and Long compress and expand intrinsic methods. Signed-off-by: Spencer Comin <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
Jenkins test sanity.functional,sanity.openjdk all jdk17,jdk21 depends eclipse-omr/omr#7740 |
JDK 17 aarch64 mac build failure is unrelated to this change. Rerunning. Jenkins test sanity.functional,sanity.openjdk amac jdk17 depends eclipse-omr/omr#7740 |
As this will require a coordinated merge, I will add the testing of JDKs 8 and 11. Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11 depends eclipse-omr/omr#7740 |
JDK 11 AIX sanity.functional test failure does not appear to be something that could be related to this change. |
Test results look good. Only failure appears to be unrelated to this change. I will wait until the contents of https://github.com/eclipse-openj9/openj9-omr/tree/openj9, https://github.com/eclipse-openj9/openj9-omr/tree/master and https://github.com/eclipse-omr/omr/tree/master are consistent before performing the coordinated merge. |
Testing was successful. OMR Pull Request #7740 has been merged and promoted. Merging. |
Use the codegen flags instead of cpu flags to check support for bitwise compress and expand IL opcodes when inlining
(Integer|Long).(compress|expand)
.Requires coordinated merge with eclipse-omr/omr#7740.