Raise allowance size threshold along alwaysWorthInlining calls #21819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vijaysun-omr Requesting review. |
In Estimate Code Size, we would terminate estimation once
_analyzedSize exceeded the analyzed size threshold, which was
obtained using sizeThreshold * allowanceFactor. However, not
increasing the analyzed size threshold for methods that are always
worth inlining - a property set through inliner policy or through
the use of @ForceInline annotation, meant that those methods were
not being prioritized as necessary. To overcome that issue, this
commit introduces a few changes to the ECS heuristics:
* forceInlineMultiplier - to be used to multiply the analyzed
size threshold for a method that is always worth inlining.
* Change estimateCodeSize function signature to be able to
recursively pass down caller method's analyzed size threshold
to callees along an always worth inlining call graph.
* Reset _analyzedSize to pre-analysis _analyzedSize for methods
always worth inlining.
Signed-off-by: Nazim Bhuiyan <[email protected]>
nbhuiyan
force-pushed
the
ecs-forceinline-final
branch
from
8eaf301 to
5d1f26b
Compare
|
Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk21 |
|
Jenkins test sanity.openjdk plinux jdk21 |
vijaysun-omr
approved these changes
May 10, 2025
|
FYI, @mpirvu @ehsankianifar @r30shah @gita-omr since changes in this area have affected results in the past for some of your benchmarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Estimate Code Size, we would terminate estimation once _analyzedSize exceeded the analyzed size threshold, which was obtained using sizeThreshold * allowanceFactor. However, not increasing the analyzed size threshold for methods that are always worth inlining - a property set through inliner policy or through the use of @ForceInline annotation, meant that those methods were not being prioritized as necessary. To overcome that issue, this commit introduces a few changes to the ECS heuristics: