Skip to content

SVM: Always specify the actual inlined method for inlined method relos #21838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025

Conversation

jdmpapin
Copy link
Contributor

@jdmpapin jdmpapin commented May 9, 2025

...and ignore the call symref. For an inlined indirect call, the inlined method can differ from the method specified by the call symref, which could result in an incorrect inlining table at load time.

...and ignore the call symref. For an inlined indirect call, the inlined
method can differ from the method specified by the call symref, which
could result in an incorrect inlining table at load time.
@jdmpapin
Copy link
Contributor Author

jdmpapin commented May 9, 2025

@dsouzai, could you please review?

@jdmpapin jdmpapin requested a review from dsouzai May 9, 2025 16:17
@dsouzai
Copy link
Contributor

dsouzai commented May 9, 2025

jenkins test sanity all jdk21

@dsouzai dsouzai self-assigned this May 9, 2025
@dsouzai
Copy link
Contributor

dsouzai commented May 10, 2025

xlinux failure is due to #21352:

[2025-05-09T18:22:55.453Z] ACTION: main -- Error. Program `/home/jenkins/workspace/Test_openjdk21_j9_sanity.openjdk_x86-64_linux_Personal_testList_0/jdkbinary/j2sdk-image/bin/java' timed out (timeout set to 960000ms, elapsed time including timeout handling was 965997ms).
[2025-05-09T18:22:55.453Z] REASON: User specified action: run main DoubleToDecimalTest 100_000 
[2025-05-09T18:22:55.453Z] TIME:   966.016 seconds
[2025-05-09T18:22:55.453Z] messages:
[2025-05-09T18:22:55.453Z] command: main DoubleToDecimalTest 100_000
[2025-05-09T18:22:55.453Z] reason: User specified action: run main DoubleToDecimalTest 100_000 
[2025-05-09T18:22:55.453Z] started: Fri May 09 18:06:36 UTC 2025
[2025-05-09T18:22:55.453Z] Mode: othervm [test or library overrides a system module]
[2025-05-09T18:22:55.453Z] Additional options from @modules: --add-modules java.base --add-exports java.base/jdk.internal.math=ALL-UNNAMED
[2025-05-09T18:22:55.453Z] Timeout information:
[2025-05-09T18:22:55.453Z] Running jcmd on process 1495124
[2025-05-09T18:22:55.453Z] Dump written to /home/jenkins/workspace/Test_openjdk21_j9_sanity.openjdk_x86-64_linux_Personal_testList_0/aqa-tests/TKG/output_17468118563561/jdk_lang_j9_0/work/scratch/2/core.20250509.182237.1495124.0001.dmp
[2025-05-09T18:22:55.453Z] Dump written to /home/jenkins/workspace/Test_openjdk21_j9_sanity.openjdk_x86-64_linux_Personal_testList_0/aqa-tests/TKG/output_17468118563561/jdk_lang_j9_0/work/scratch/2/javacore.20250509.182241.1495124.0002.txt
[2025-05-09T18:22:55.453Z] Running jstack on process 1495124
[2025-05-09T18:22:55.453Z] 2025-05-09T18:22:42.055545715
[2025-05-09T18:22:55.453Z] Virtual machine: 1495124 JVM information:
[2025-05-09T18:22:55.453Z] JRE 21 Linux amd64-64-Bit 20250509_632 (JIT enabled, AOT enabled)
[2025-05-09T18:22:55.453Z] OpenJ9   - b8539a872f6
[2025-05-09T18:22:55.453Z] OMR      - 06bd680ed07
[2025-05-09T18:22:55.453Z] JCL      - 4a9e219dca5 based on jdk-21.0.8+2
[2025-05-09T18:22:55.453Z] 
[2025-05-09T18:22:55.453Z] "main" prio=5 Id=2 WAITING
[2025-05-09T18:22:55.453Z] 	at [email protected]/java.lang.Object.waitImpl(Native Method)

Windows job succeeded, but for some reason isn't able to update the github status.

Merging.

@dsouzai dsouzai merged commit 3dc11e7 into eclipse-openj9:master May 10, 2025
24 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants