Add JFR YoungGenerationConfiguration Event #21840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tajila please review |
adpopescu
force-pushed
the
gc-young-generation-config
branch
from
ecdcce5 to
bd0c143
Compare
theresa-m
reviewed
May 12, 2025
adpopescu
force-pushed
the
gc-young-generation-config
branch
from
bd0c143 to
524fe6c
Compare
This change adds support for the JFR Young Generation Configuration Event. Signed-off-by: Adrian Popescu <[email protected]>
adpopescu
force-pushed
the
gc-young-generation-config
branch
from
524fe6c to
b4c6d79
Compare
theresa-m
approved these changes
May 13, 2025
|
jenkins test sanity.functional xlinux jdk17 |
tajila
approved these changes
May 14, 2025
keithc-ca
reviewed
May 14, 2025
| youngGenConfiguration->minSize = mmFuncs->j9gc_get_minimum_young_generation_size(vm); | ||
| youngGenConfiguration->maxSize = mmFuncs->j9gc_get_maximum_young_generation_size(vm); | ||
| if (0 != mmFuncs->j9gc_get_maximum_young_generation_size(vm)) { | ||
| youngGenConfiguration->newRatio = mmFuncs->j9gc_get_maximum_heap_size(vm)/mmFuncs->j9gc_get_maximum_young_generation_size(vm) - 1; |
There was a problem hiding this comment.
Missing parentheses, spaces around /.
There was a problem hiding this comment.
@adpopescu Please add that change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for the JFR Young Generation Configuration Event.