Update CRC32C acceleration for off-heap #21852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Marking this WIP while I launch a personal test build. |
|
launched personal build for verification. |
|
Do you mean CRC32C? |
VermaSh
changed the title
|
ah, dang, missed the C. I'll update the commit |
VermaSh
force-pushed
the
enableCRC32
branch
3 times, most recently
from
3794477 to
5111063
Compare
VermaSh
changed the title
|
This PR is ready, @Spencer-Comin , @r30shah Can I please get a review? |
Comment on lines
2237
to
2248
| if (TR::Compiler->om.isOffHeapAllocationEnabled()) | ||
| { | ||
| // Load first data element address | ||
| generateRXInstruction(cg, | ||
| TR::InstOpCode::getLoadOpCode(), | ||
| node, | ||
| array, | ||
| generateS390MemoryReference(array, cg->comp()->fej9()->getOffsetOfContiguousDataAddrField(), cg)); | ||
|
|
||
| // Since the first data element address is retrieved from the array header, the offset is set to 0 | ||
| offsetToDataElements = 0; | ||
| } |
There was a problem hiding this comment.
Does this work for the updateDirectByteBuffer as well?
There was a problem hiding this comment.
I have just updated the if condition. From what I understand directByteBuffer is supposed to be a contiguous memory off heap so we should be good using the passed in address without doing anything special in off-heap mode. @amicic Can you please confirm?
There was a problem hiding this comment.
Not expert, but yes DBB probably has an explicit pointer to the memory. DBB has nothing to do with Java Arrays, hence no dataAddr awareness (but I guess, onцe you reach the memory, you are free to apply some of array specific optimizations).
r30shah
requested changes
May 16, 2025
Comment on lines
2234
to
2235
| // Offset to be added to array object pointer to get to the data elements | ||
| int32_t offsetToDataElements = isDirectBuffer ? 0 : TR::Compiler->om.contiguousArrayHeaderSizeInBytes(); |
There was a problem hiding this comment.
Suggested change
| // Offset to be added to array object pointer to get to the data elements | |
| int32_t offsetToDataElements = isDirectBuffer ? 0 : TR::Compiler->om.contiguousArrayHeaderSizeInBytes(); | |
| // Offset to be added to array object pointer to get to the data elements | |
| int32_t offsetToDataElements = isDirectBuffer ? 0 : static_cast<int32_t>(TR::Compiler->om.contiguousArrayHeaderSizeInBytes()); |
|
Jenkins test sanity zlinux jdk11,jdk21 |
|
@VermaSh Please wait for the tests to finish before you apply minor nitpick change |
Spencer-Comin
approved these changes
May 16, 2025
|
Don't think the failure is related to my changes. It looks similar to the stack trace in other failures due to #21720 |
The acceleration was initially disabled because it added array header size to the array object, which was required to reach the elements. However, this is unnecessary for off-heap mode. As a result, the evaluator has been updated to add the array header size exclusively for non-off-heap mode, while in off-heap mode, it now retrieves the data element address directly from the array header, enabling acceleration in off-heap mode. Signed-off-by: Shubham Verma <[email protected]>
|
@r30shah I have updated the PR with your suggestion. |
|
jenkins test sanity zlinux jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The acceleration was initially disabled because it added array header size to the array object, which was required to reach the elements. However, this is unnecessary for off-heap mode. As a result, the evaluator has been updated to add the array header size exclusively for non-off-heap mode, while in off-heap mode, it now retrieves the data element address directly from the array header, enabling acceleration in off-heap mode.