Skip to content

Enable EncodeASCII acceleration for off-heap #21855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2025
Merged

Enable EncodeASCII acceleration for off-heap #21855

merged 1 commit into from
May 20, 2025

Conversation

VermaSh
Copy link
Contributor

@VermaSh VermaSh commented May 12, 2025

This already uses
TR::TransformUtil::generateFirstArrayElementAddressTrees API to generate appropriate trees for off-heap and non off-heap modes so no change is needed to the evaluator.

@VermaSh
Copy link
Contributor Author

VermaSh commented May 12, 2025

Marking this WIP while I launch a personal test build.
cc: @r30shah @zl-wang @dchopra001

@VermaSh
Copy link
Contributor Author

VermaSh commented May 12, 2025 •
edited
Loading

launched personal build for verification.

@VermaSh
Enable EncodeASCII acceleration for off-heap
4cc160c 
This already uses
`TR::TransformUtil::generateFirstArrayElementAddressTrees`  API to
generate appropriate trees for off-heap and non off-heap modes so
no change is needed to the evaluator.

Signed-off-by: Shubham Verma <[email protected]>
@VermaSh VermaSh force-pushed the enableEncodeASCII branch from 426bea5 to 4cc160c Compare May 14, 2025 18:03
@VermaSh VermaSh changed the title WIP: Enable EncodeASCII acceleration for off-heap Enable EncodeASCII acceleration for off-heap May 16, 2025
@VermaSh VermaSh marked this pull request as ready for review May 16, 2025 03:08
@VermaSh
Copy link
Contributor Author

VermaSh commented May 16, 2025

My personal build passed without any failures. @dchopra001, @r30shah , @zl-wang Can I please get a review?

@r30shah
Copy link
Contributor

r30shah commented May 16, 2025

Jenkins test sanity zlinux jdk11,jdk21

r30shah
r30shah approved these changes May 16, 2025
View reviewed changes
Copy link
Contributor

@r30shah r30shah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VermaSh
Copy link
Contributor Author

VermaSh commented May 20, 2025

@dchopra001 / @zl-wang Can I please get final set or reviews?

zl-wang
zl-wang approved these changes May 20, 2025
View reviewed changes
Copy link
Contributor

@zl-wang zl-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zl-wang zl-wang merged commit 9dd36a5 into eclipse-openj9:master May 20, 2025
9 checks passed
@zl-wang
Copy link
Contributor

zl-wang commented May 20, 2025

sorry @r30shah I hit the merge button too soon, should leave it for you to merge;
@VermaSh double-check with you: the fast-pathing (or special-casing in your usual terminology) codegen location already took care of array addressing for off-heap such that you didn't need to change it in this very PR?

@VermaSh
Copy link
Contributor Author

VermaSh commented May 21, 2025

@zl-wang yup that's correct

@r30shah
Copy link
Contributor

r30shah commented May 21, 2025

sorry @r30shah I hit the merge button too soon, should leave it for you to merge;

No worries - Needed to get this one in before we split for 0.53 so all good.

@VermaSh VermaSh deleted the enableEncodeASCII branch May 21, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r30shah r30shah r30shah approved these changes

@zl-wang zl-wang zl-wang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VermaSh @r30shah @zl-wang