-
Notifications
You must be signed in to change notification settings - Fork 767
Enable vectorizedHashCode intrinsic for OffHeap on POWER #21856
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Calculate the address for the array data in OffHeap mode correctly for vectorizedHashCode Signed-off-by: Luke Li <[email protected]>
FYI @zl-wang |
Performance numbers:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
almost identical code between gencon and offheap ... it is somewhat unexpected that int[2] & int[3] performance are not closer to gencon, isn't it? should be more than 90% of the gencon corresponding numbers. |
I did some more runs and the numbers were the same, so they should be accurate. My guess is that the extra load required is significant enough on the short arrays. |
Jenkins test sanity aix,plinux jdk8,jdk21 |
in particular, for int[3], how long is the sequence for gencon and off-heap respectively? we can figure out if the load vs. addi (that is the only difference) can explain it. |
It turns out the old numbers for int[3] were wrong. All the new tests I run have 375 for gencon and 333 for offheap. The other lengths' throughputs are still consistent. |
better. please update the performance numbers. |
Numbers has been updated here: #21856 (comment) |
Calculate the address for the array data in OffHeap mode correctly for vectorizedHashCode