Update non-FLC flatlock exit to use CAS #21877
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengxue-IS
force-pushed
the
21826
branch
2 times, most recently
from
d9c2917 to
f001376
Compare
babsingh
reviewed
May 16, 2025
fengxue-IS
force-pushed
the
21826
branch
2 times, most recently
from
5ccf3dc to
f6ef0b1
Compare
|
changes ltgm, @fengxue-IS can you squash the commits? |
|
jenkins test sanity plinux jdk21 |
|
jenkins test sanity alinux jdk24 |
- Use CompareAndSwap to ensure updates to lockword is not overwritten during exit. - Also ensure vthread blocked on monitor is notified properly. - Create separate jdk24+ monitorexit code path Signed-off-by: Jack Lu <[email protected]>
|
@babsingh can you please restart the PR builds, I think the squash accidentally removed an extra line of code. |
|
jenkins test sanity alinux jdk24 |
|
jenkins test sanity plinux jdk21 |
|
jenkins compile win jdk24 |
babsingh
approved these changes
May 23, 2025
keithc-ca
reviewed
May 23, 2025
| } | ||
| } else { | ||
| j9objectmonitor_t newLock = 0; | ||
| I_32 casSuccess = FALSE; |
There was a problem hiding this comment.
The type of casSuccess should be BOOLEAN.
There was a problem hiding this comment.
Opened #21935 to address it.
babsingh
added a commit
to babsingh/openj9
that referenced
this pull request
May 23, 2025
Related: eclipse-openj9#21877 Signed-off-by: Babneet Singh <[email protected]>
|
@fengxue-IS Can you address the following concerns, which were missed?
|
This was referenced May 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use CompareAndSwap to ensure updates to lockword is not overwritten during exit.
Also ensure vthread blocked on monitor is notified properly.
Related: #21826