Add JFR SystemGC event #21882
Merged
Add JFR SystemGC event #21882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thallium
force-pushed
the
jfr-gc-event
branch
3 times, most recently
from
9f28d17 to
c25dd5a
Compare
|
@tajila can you please review? |
tajila
reviewed
May 14, 2025
tajila
reviewed
May 14, 2025
tajila
reviewed
May 14, 2025
tajila
reviewed
May 15, 2025
|
Please also add a test case. |
thallium
force-pushed
the
jfr-gc-event
branch
2 times, most recently
from
3e597b3 to
ba218a0
Compare
|
Added a test |
|
jenkins test sanity.functional xlinux jdk17 |
tajila
reviewed
May 20, 2025
tajila
reviewed
May 20, 2025
| @@ -104,4 +104,11 @@ SPDX-License-Identifier: EPL-2.0 OR Apache-2.0 OR GPL-2.0-only WITH Classpath-ex | |||
| <output type="required" caseSensitive="yes" regex="no">topAddress</output> | |||
| <output type="failure" caseSensitive="yes" regex="no">jfr print: could not read recording</output> | |||
| </test> | |||
| <test id="test jfr SystemGC - approx 30 seconds" platforms="linux.*"> | |||
There was a problem hiding this comment.
this isnt specific to linux so it doesnt need platforms="linux.*"
There was a problem hiding this comment.
you also probably need to trigger a System.gc() in WorkLoad.java, maybe after a thread completes
There was a problem hiding this comment.
also, I tried a sample application and didnt see the system GC event
There was a problem hiding this comment.
The test should work now.
also, I tried a sample application and didnt see the system GC event
Did you call the System.gc() and can you share your application? It seems working for me.
Closes eclipse-openj9#21859 Signed-off-by: Gengchen Tuo <[email protected]>
|
jenkins test sanity.functional xlinux jdk17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21859