Skip to content

Fix style and consistency issues in some JFR events #21891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

adpopescu
Copy link
Contributor

@adpopescu adpopescu commented May 15, 2025

This change fixes style and consistency issues in some JFR event code.

@adpopescu
Copy link
Contributor Author

@tajila

@tajila tajila requested a review from keithc-ca May 15, 2025 16:54
@tajila
Copy link
Contributor

tajila commented May 15, 2025

@keithc-ca Please review these changes

Copy link
Contributor

@keithc-ca keithc-ca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update the commit message:

  • it should start with "Fix", not "Fixes"
  • the summary line should not end with a period
  • please spell JFR consistently

@adpopescu adpopescu force-pushed the gc-young-generation-fixes branch from bf0fad2 to 5067d97 Compare May 15, 2025 19:03
@adpopescu adpopescu changed the title Fixes style and consistency issues in some JFR events. Fix style and consistency issues in some JFR events. May 15, 2025
@adpopescu adpopescu changed the title Fix style and consistency issues in some JFR events. Fix style and consistency issues in some JFR events May 15, 2025
@adpopescu adpopescu force-pushed the gc-young-generation-fixes branch 2 times, most recently from 12d18ff to 75ac1d7 Compare May 15, 2025 20:11
@keithc-ca
Copy link
Contributor

The summary line in the commit message still ends with a period (but should not).

@adpopescu
Copy link
Contributor Author

adpopescu commented May 15, 2025

The summary line in the commit message still ends with a period (but should not).

I had changed it on the commit. It was still in the buffer when I amended, unfortunately.

This change fixes style and consistency issues in some JFR event code.

Signed-off-by: Adrian Popescu <[email protected]>
@adpopescu adpopescu force-pushed the gc-young-generation-fixes branch from e2404ae to 96c0646 Compare May 15, 2025 21:09
@adpopescu adpopescu requested a review from keithc-ca May 16, 2025 12:43
@keithc-ca
Copy link
Contributor

Jenkins test sanity zlinux jdk21

@keithc-ca keithc-ca merged commit db897b1 into eclipse-openj9:master May 21, 2025
6 checks passed
@adpopescu adpopescu deleted the gc-young-generation-fixes branch May 22, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants