Fix is{Anonymous,Hidden}Class() for 64-bit big-endian JITServer #21925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For CLASSINFO_ROMCLASS_EXTRAMODIFIERS the result is uint32_t, but these call sites were passing a pointer to uintptr_t, which on 64-bit is twice as big as necessary. On a big-endian system, the result would be stored to the high half of the variable, leaving the low half zero, so these functions would return false for all classes.
|
@dsouzai, could you please review? |
dsouzai
approved these changes
May 21, 2025
|
jenkins test sanity.functional xlinuxjit,plinuxjit,zlinuxjit jdk21 |
mpirvu
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
CLASSINFO_ROMCLASS_EXTRAMODIFIERSthe result isuint32_t, but these call sites were passing a pointer touintptr_t, which on 64-bit is twice as big as necessary. On a big-endian system, the result would be stored to the high half of the variable, leaving the low half zero, so these functions would return false for all classes.