Fold calls to Invokers.checkVarHandleGenericType into its result #21998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbhuiyan
force-pushed
the
chk-vhgentype-fold
branch
from
e5a3d9c to
b9542a8
Compare
|
@jdmpapin I'd appreciate your review of this. @vijaysun-omr FYI, this will improve performance in VarHandle and MemorySegment-heavy workloads. |
nbhuiyan
commented
Jun 2, 2025
jdmpapin
reviewed
Jun 2, 2025
nbhuiyan
force-pushed
the
chk-vhgentype-fold
branch
from
b9542a8 to
c14dd0f
Compare
nbhuiyan
force-pushed
the
chk-vhgentype-fold
branch
from
c14dd0f to
23b1508
Compare
|
@jdmpapin I have addressed your review comments. Requesting another review. |
nbhuiyan
force-pushed
the
chk-vhgentype-fold
branch
from
23b1508 to
440fa51
Compare
jdmpapin
reviewed
Jun 5, 2025
nbhuiyan
force-pushed
the
chk-vhgentype-fold
branch
from
440fa51 to
099bd46
Compare
jdmpapin
approved these changes
Jun 5, 2025
|
|
|
Jenkins test sanity all jdk17,jdk21 |
|
Jenkins test sanity.openjdk zlinux jdk21 |
|
Jenkins test sanity xlinuxjit,plinuxjit,zlinuxjit jdk17,jdk21 |
The value is used to access MethodHandles in a VarHandle's MethodHandle table. This capability was separated out of getMethodHandleTableEntryIndex as it is required outside of that function to generate trees to load from the MethodHandle table. Also implemented JITServer support. Signed-off-by: Nazim Bhuiyan <[email protected]>
When the VarHandle object and the AccessDescriptor objects are known, we can perform a compile-time lookup of the corresponding entry in the VarHandle's MethodHandle table. This commit enables such a transformation through the following: * Add recognized fields from which the MethodHandle table gets loaded, accounting for the differences different JDK versions * Add checkVarHandleGenericType to the list of non-inlinable methods * Add new function in MethodHandleTransformer to be triggered when visiting checkVarHandleGenericType call node that generates the trees and transforms the call node. Signed-off-by: Nazim Bhuiyan <[email protected]>
nbhuiyan
force-pushed
the
chk-vhgentype-fold
branch
from
099bd46 to
a27d80d
Compare
|
@jdmpapin The merge conflict is now resolved. |
|
Running some minimal additional testing since the previous checks were done a month ago Jenkins test sanity xlinux jdk17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the VarHandle object and the AccessDescriptor objects are known, we can perform a compile-time lookup of the corresponding entry in the VarHandle's MethodHandle table. This commit enables such a
transformation through the following:
Furthermore, visitStoreToLocalVariable can now be triggered for cases of direct stores of nodes anchored by PassThrough nodes, which would result from calls that have been transformed into PassThrough. PassThrough nodes do not have type info, and therefore this has to be accounted for. Once inside visitStoreToLocalVariable, it would have to recognize cases of stores of child nodes of PassThrough, and set the actual node to use as the RHS of the store.