Remove TR_X87_Mask guarded code #22103
Conversation
X87 registers are no longer allocated. Signed-off-by: Spencer Comin <[email protected]>
|
Internal testing here |
|
@BradleyWood : please review |
| @@ -71,14 +71,11 @@ TR::Snippet *TR::X86MemImmSnippetInstruction::getSnippetForGC() | |||
| void TR::X86MemImmSnippetInstruction::assignRegisters(TR_RegisterKinds kindsToBeAssigned) | |||
| { | |||
| TR::X86MemImmInstruction::assignRegisters(kindsToBeAssigned); | |||
| if (kindsToBeAssigned & (TR_X87_Mask | TR_FPR_Mask)) | |||
| if (kindsToBeAssigned & TR_FPR_Mask) | |||
There was a problem hiding this comment.
Can you confirm if TR_X87_Mask is ever set? If its not, then this probably doesn't depend on eclipse-omr/omr#7799 and we can avoid a coordinated merge situation.
There was a problem hiding this comment.
It would avoid a coordinated merge, but I think this pull request would need to be merged before eclipse-omr/omr#7799 could be merged.
There was a problem hiding this comment.
@BradleyWood I don't see anywhere TR_X87_Mask is set. To be safe, I started an internal build without eclipse-omr/omr#7799. All the tests passed; I'd say this doesn't depend on eclipse-omr/omr#7799.
|
Given testing in #22103 (comment), we don't need a coordinated merge with eclipse-omr/omr#7799 |
|
Jenkins test sanity xlinux,win32 jdk8 |
| { | ||
| TR::UnresolvedDataSnippet *snippet = getMemoryReference()->getUnresolvedDataSnippet(); | ||
| if (snippet) | ||
| { | ||
| if (kindsToBeAssigned & TR_X87_Mask) | ||
| snippet->setNumLiveX87Registers(cg()->machine()->fpGetNumberOfLiveFPRs()); | ||
|
|
||
| if (kindsToBeAssigned & TR_FPR_Mask) |
There was a problem hiding this comment.
Isn't this test now redundant?
There was a problem hiding this comment.
Do you mean the if (kindsToBeAssigned & TR_FPR_Mask) test?
There was a problem hiding this comment.
Yes, it's (now) the same test as on line 74, which we know is true here.
There was a problem hiding this comment.
I'll remove that in a future PR together with some other dead x87 code
X87 registers are no longer allocated.
Requires coordinated merge with eclipse-omr/omr#7799