Update the cmake minimum version to 3.5 #22154
Conversation
Signed-off-by: Peter Shipton <[email protected]>
|
The minimum must also be increased in OMR - 3.2 will not be accepted by cmake 4.1. |
Is that for building OMR, or do the places in OMR affect the OpenJ9 build? |
See https://github.com/eclipse-omr/omr/blob/master/CMakeLists.txt#L26 which applies to the OMR portion when used in OpenJ9. |
|
I saw the places, I'm not convinced they affect an OpenJ9 build since afaik OpenJ9 doesn't build OMR from the top level (although I'm easily wrong), unless in your testing you've encountered a problem? |
Yes. Using a newer version of cmake leads to a fatal error unless both OMR and OpenJ9 are modified. |
|
It will have to wait until after Canada Day vacations. |
|
We don't need to change the minimum, just opt into policy changes of newer versions; see #22161 and eclipse-omr/omr#7817 (which can be merged independently). |
|
Reopening: #22161 was reverted. |
|
Sorry, meant to reopen #19445, not this. |
|
jenkins compile aix jdk11 |
|
Is this intended to just be stop-gap until a working version of #22161 is available?
We'll still need a similar change in OMR before anyone could use cmake 4.0.x. |
Could be. First I wanted to check if this change caused the AIX build problem. I'll enquire about changing OMR. |
This maintains compatibility with some 4.0.x versions. Related to eclipse-openj9/openj9#22154 Signed-off-by: Peter Shipton <[email protected]>
|
As long as there are no objections from the OMR community, the OMR cmake minimum will be updated to 3.5. |
|
This won't be fully effective until eclipse-omr/omr#7826 promotes, but I see no reason to delay merging this. |
See some discussion in https://github.ibm.com/runtimes/infrastructure/issues/10196 about compatibility with cmake 4.x