Skip to content

AArch64: Add support for off-heap arrays in some intrinsics #22192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2025

Conversation

knn-k
Copy link
Contributor

@knn-k knn-k commented Jul 7, 2025

This commit adds support for off-heap arrays in some intrinsics for AArch64.

@knn-k
Copy link
Contributor Author

knn-k commented Jul 7, 2025

Jenkins test sanity amac,alinux64 jdk21

@knn-k
Copy link
Contributor Author

knn-k commented Jul 7, 2025

Related issue: #22184

@knn-k knn-k marked this pull request as ready for review July 8, 2025 06:24
@0xdaryl
Copy link
Contributor

0xdaryl commented Jul 9, 2025

The code looks fine. Can you change your commit and PR message though to reflect the fact that this is adding support for off-heap arrays in some intrinsics. Otherwise, the message is pretty general.

No need to re-run CI if that's the only change you make.

This commit adds support for off-heap arrays in some intrinsics for AArch64.

Signed-off-by: KONNO Kazuhiro <[email protected]>
@knn-k knn-k force-pushed the aarch64IntrinsicsOffHeap branch from ebf0f11 to b270fdf Compare July 9, 2025 22:49
@knn-k knn-k changed the title AArch64: Add support for off-heap arrays AArch64: Add support for off-heap arrays in some intrinsics Jul 9, 2025
@knn-k
Copy link
Contributor Author

knn-k commented Jul 9, 2025

I updated the commit title and the title of this PR.

@0xdaryl 0xdaryl merged commit 2f546a6 into eclipse-openj9:master Jul 9, 2025
2 checks passed
@knn-k knn-k deleted the aarch64IntrinsicsOffHeap branch July 9, 2025 22:52
knn-k added a commit to knn-k/openj9 that referenced this pull request Jul 11, 2025
knn-k added a commit to knn-k/openj9 that referenced this pull request Jul 11, 2025
This commit reverts the inlineIntrinsicIndexOf() part of PR eclipse-openj9#22192,
due to the failure with JDK 24.

Fixes: eclipse-openj9#22205
0xdaryl added a commit that referenced this pull request Jul 11, 2025
zl-wang pushed a commit to zl-wang/openj9 that referenced this pull request Aug 12, 2025
This commit reverts the inlineIntrinsicIndexOf() part of PR eclipse-openj9#22192,
due to the failure with JDK 24.

Fixes: eclipse-openj9#22205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants