Set blockPermit for BLOCKING thread when lock is free #22215
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theresa-m
force-pushed
the
vthreadmonitortest
branch
from
66d42ef to
d30be2e
Compare
fengxue-IS
reviewed
Jul 11, 2025
runtime/vm/ContinuationHelpers.cpp
Outdated
| { | ||
| omrthread_monitor_t monitor = syncObjectMonitor->monitor; | ||
| /* Only set the VirtualThread.blockPermit if thread is ready to be unblocked. | ||
| * All blocking/waiting monitor have to be inflated, if the monitor has not been inflated, |
There was a problem hiding this comment.
Can you update. the comment here to reflect only blocking/blocked need this check. also include that the BLOCKPERMIT will allow afterYield() function to reschedule the thread.
There was a problem hiding this comment.
I updated the comments for BLOCKED and BLOCKING.
theresa-m
force-pushed
the
vthreadmonitortest
branch
from
d30be2e to
133d822
Compare
theresa-m
force-pushed
the
vthreadmonitortest
branch
from
0d240be to
0c50040
Compare
|
Thanks @babsingh I updated the code with your suggestions and fixed additional similar cases. |
|
@theresa-m Can you squash the commits? The second commit has incorrect details: |
Only set VirtualThread.blockPermit for a virtual thread in the BLOCKING state when the lock is available. This prevents virtual threads from being unblocked prematurely. Signed-off-by: Theresa Mammarella <[email protected]>
theresa-m
force-pushed
the
vthreadmonitortest
branch
from
0c50040 to
b9639a8
Compare
Done |
|
jenkins test sanity amac jdk24 |
babsingh
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only set VirtualThread.blockPermit for a virtual thread in the BLOCKING state when the lock is available. This prevents virtual threads from being unblocked prematurely.
Fixes: #22077
Grinder: https://hyc-runtimes-jenkins.swg-devops.com/view/Test_grinder/job/Grinder/52611/