Set known object index for condy and method type table entry symrefs #22235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hzongaro, could you please review? |
hzongaro
reviewed
Jul 17, 2025
These symbols satisfy isFixedObjectRef(), allowing in some circumstances for the JIT to attempt to load and dereference them at compile time. Soon the compiler will start to keep track within each compilation of where each known object was found, and having known object indices for these symrefs will facilitate the tracking. The dereferencing paths also handle known objects. They need to be aware of isFixedObjectRef() only because there are some for which the known object index is missing. So setting known object indices on these symrefs as appropriate will allow that code to be simplified (as a follow-up).
|
Updated to use |
|
Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk17,jdk21 |
|
The 64-bit Windows JDK21 build failure is #17693 Jenkins test sanity.functional,sanity.openjdk win jdk21 |
|
Test_openjdk8_j9_sanity.functional_x86-32_windows_Personal: cmdLineTester_J9securityTests_SE80_0 failed with Test_openjdk21_j9_sanity.functional_s390x_linux_Personal: Known issue #13684 |
|
All tests have passed except for the aforementioned known issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These symbols satisfy
isFixedObjectRef(), allowing in some circumstances for the JIT to attempt to load and dereference them at compile time. Soon the compiler will start to keep track within each compilation of where each known object was found, and having known object indices for these symrefs will facilitate the tracking. The dereferencing paths also handle known objects. They need to be aware ofisFixedObjectRef()only because there are some for which the known object index is missing. So setting known object indices on these symrefs as appropriate will allow that code to be simplified (as a follow-up).