(0.54) Guard peeking behaviour for invokedynamic/handle with an env option #22290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@0xdaryl Requesting review |
|
eclipse-omr/omr#7320 (comment) should be addressed before this is merged. |
keithc-ca
requested changes
Jul 23, 2025
There was a problem hiding this comment.
This won't compile on all platforms, e.g. z/OS where it complains:
[2025-07-23T18:57:31.713Z] "/jenkins/workspace/Build_JDK21_s390x_zos_Personal@2/openj9/runtime/compiler/optimizer/J9EstimateCodeSize.cpp", line 992.10: CCN5246 (S) The "case" statement bypasses the initialization of "const bool enablePeekingForMHInvokes".
|
In draft state until changes from #22295 are included here upon review + merge of that PR. |
|
I think this should be squashed: we don't need to repeat the misstep that occurred in the master branch. |
This commit disables peeking ILGen due to presence of invokedynamic or invokehandle bytecodes. This is meant to be a temporary measure until DDR test failures caused with such peeking ILGen can be investigated and fixed. Peeking ILGen for non-root methods containing invokedynamic/invokehandle bytecodes would now have to be enabled using the option TR_enablePeekingForMHInvokes. Signed-off-by: Nazim Bhuiyan <[email protected]>
nbhuiyan
force-pushed
the
guard-nph-mhinvoke-0.54
branch
from
67143e7 to
e838fe7
Compare
|
@keithc-ca is this good to merge now? |
keithc-ca
approved these changes
Jul 24, 2025
pshipton
approved these changes
Jul 24, 2025
This was referenced Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double-delivering #22284 and #22295 for 0.54.
Issue: #22256