(0.54) Modify objectMonitorExit to use OBJECT_HEADER_LOCK_FLC instead of 0x02 #22307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When debugging issues related to OBJECT_HEADER_LOCK_FLC, global search of `OBJECT_HEADER_LOCK_FLC` will miss this piece of code, which makes things harder. If the code is checking for a macro, use the macro rather than its value. Signed-off-by: Hang Shao <[email protected]>
|
@TobiAjila @babsingh Could one of you merge this port ? |
babsingh
approved these changes
Jul 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When debugging issues related to
OBJECT_HEADER_LOCK_FLC, global search ofOBJECT_HEADER_LOCK_FLCwill miss this piece of code, which makes things harder. If the code is checking for a macro, use the macro rather than its value.Port of #22294