(0.54) Add spill registers in walkTransitionFrame() #22333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ehsankianifar You need to rebase your changes on the 0.54 branch. Also please add a link to the original change in your commit message. |
ehsankianifar
force-pushed
the
UpdateSpillRegisters
branch
from
4ab7d0e to
7c02e15
Compare
ehsankianifar
force-pushed
the
UpdateSpillRegisters
branch
from
7c02e15 to
f8df009
Compare
ehsankianifar
changed the title
ehsankianifar
force-pushed
the
UpdateSpillRegisters
branch
from
0f69090 to
fac3ca0
Compare
|
@tajila thanks for your comment. |
There are cases that the stack walker walk jit frames in transition frame e.g. when a virtual thread fails to enter a synchronized method. We still walk the register map in transition frame if there are object slots in registers but we don't update the register table with spilled registers which is causing failure. This PR add procedure to update register table with spilled register when it is in method prologue for synchronized method cases. Closes: eclipse-openj9#22079 Backport of: eclipse-openj9#22303 Signed-off-by: Ehsan Kiani Far <[email protected]>
ehsankianifar
force-pushed
the
UpdateSpillRegisters
branch
from
fac3ca0 to
c248dd8
Compare
pshipton
approved these changes
Jul 30, 2025
This was referenced Jul 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases that the stack walker walk jit frames in transition frame e.g. when a virtual thread fails to enter a synchronized method. We still walk the register map in transition frame if there are object slots in registers but we don't update the register table with spilled registers which is causing failure.
This PR add procedure to update register table with spilled register when it is in method prologue for synchronized method cases.
Closes: #22079
Backport of #22303