(v0.54.0) Undefine conflicting macro in header file #22417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Missing period. Please fix the description and the commit message. |
thrtypes.h includes dependency to <fcntl.h> which on AIX contains macro: #define open open64 This conflicts with other uses of the name "open" in files that includes "ContinuationHelpers.hpp". Signed-off-by: Jack Lu <[email protected]>
fengxue-IS
force-pushed
the
054-vt22410
branch
from
bdf86f5 to
ee6bec0
Compare
keithc-ca
approved these changes
Aug 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thrtypes.h includes dependency to <fcntl.h> which on AIX contains macro: #define open open64
This conflicts with other uses of the name "open" in files that includes "ContinuationHelpers.hpp".
Backport of #22413