Skip to content

refactor: replace lodash.isequal, lodash.escaperegexp with es-toolkit/compat #9223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

seokju-na
Copy link

This PR replaces lodash.isequal, lodash.escaperegexp dependency in electron-updater with es-toolkit/compat.

  • lodash.isequal 4.5.0 is deprecated
  • es-toolkit is more modern and performant than lodash.
  • es-toolkit/compat passes all lodash test cases and maintains 100% interface compatibility.

Copy link

changeset-bot bot commented Jul 29, 2025

🦋 Changeset detected

Latest commit: 42e1552

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@absidue
Copy link

absidue commented Jul 30, 2025

electron-updater is shipped with applications, so pulling in a 2.49 MB dependency into every app that uses auto-updates just for two tiny utility functions really doesn't seem like a good idea.

And no es-toolkit being tree-shakable is not good enough because many Electron applications do not use a bundler, so they will end up with the entirety of es-toolkit being shipped to their users.

Copy link
Collaborator

@mmaietta mmaietta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

electron-updater is shipped with applications, so pulling in a 2.49 MB dependency into every app that uses auto-updates just for two tiny utility functions really doesn't seem like a good idea.

This is a really great callout and something we should take into account. I also agree that this large dependency is probably not the best route. Is there any way we could just extract the necessary functions into electron-builder so that it's isolated code additions?

Otherwise, we should look into alternative packages to replace the deprecated versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants