fix(nsis): Change the ProgID to a more correct, more unique format #9241
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #9229
Change the format of the ProgID to something more unique.
The format recommended by Microsoft is:
[Program].[Component].[Version]
https://learn.microsoft.com/windows/win32/shell/fa-progids#programmatic-identifier-elements-used-by-file-associations
https://learn.microsoft.com/windows/win32/com/-progid--key
In this PR, we set it as follows:
This is useful if you have different versions of the same application installed at the same time, but electron
-builder doesn't seem to expect this.
UUID.v5(name || ext, guid)
up to the maximum ProgID.I believe this will allow for the generation of unique ProgIDs while maintaining a certain degree of readability in the registry.
Is the Changeset patch correct?
I consider this change an undocumented, detailed behavior change in electron-builder.
However, custom NSIS scripts that expect the ProgID to be name or ext may no longer work correctly.