Support Mistral-3.1-24B #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the Mistral-3.1-24B model by enabling image handling and reusing the pixtral script. Key changes include updating dependency specifications in setup.py, modifying model training and state dict loading logic, and extending image processing and encoder modules with new parameters and patch merging functionality.
Reviewed Changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Added dependency for pydantic version constraint |
| eole/models/model.py | Updated training logic and state dict loading behavior |
| eole/inputters/text_corpus.py | Introduced image_patch_size parameters in corpus processing |
| eole/inputters/dynamic_iterator.py | Added image_patch_size support in iterator configuration |
| eole/encoders/vision.py | Added PatchMerger and updated VisionLanguageAdapter to incorporate patches |
| eole/config/run.py | Removed batch_size assertion for vision models |
| eole/config/models.py | Added new fields for adapter bias and spatial merge configuration |
Files not reviewed (1)
- docs/source/Config/models.rst: Language not supported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now works with images, same script as pixtral.