eth/downloader: skip nil peer in GetHeader #32369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhaumikmaan
reviewed
Aug 7, 2025
| @@ -52,7 +52,7 @@ func (d *Downloader) GetHeader(hash common.Hash) (*types.Header, error) { | |||
|
|
|||
| for _, peer := range d.peers.peers { | |||
| if peer == nil { | |||
There was a problem hiding this comment.
Please add a warning level log here, indicating the nil peer is encountered.
There was a problem hiding this comment.
Please add a warning level log here, indicating the nil peer is encountered.
Yes, done
There was a problem hiding this comment.
Maybe bit late for this comment, but I'm not too happy about the log message. Log messages are for users, but this warning is not something the user has any chance of fixing. I honestly don't know when a nil peer will even be encountered here. So it'd be good to research why this condition can happen, and fix it, instead of printing a weird warning.
rjl493456442
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GetHeader function was incorrectly returning an error when encountering
nil peers in the peers list, which contradicted the comment "keep retrying
if none are yet available".
Changed the logic to skip nil peers with 'continue' instead of returning
an error, allowing the function to properly iterate through all available
peers and attempt to retrieve the target header from each valid peer.
This ensures the function behaves as intended - trying all available peers
before giving up, rather than failing on the first nil peer encountered.