Skip to content

downloader/queue_test: correct makeChain comment to match implementation #32382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sashass1315
Copy link
Contributor

The previous comment stated that every 3rd block has a tx and every 5th has an uncle.
The implementation actually adds one transaction to every second block and does not add uncles.
Updated the comment to reflect the real behavior to avoid confusion when reading tests.

@MariusVanDerWijden MariusVanDerWijden merged commit 2485d09 into ethereum:master Aug 11, 2025
4 of 5 checks passed
@rjl493456442 rjl493456442 added this to the 1.16.3 milestone Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants