Skip to content

Use QR Code for Setup #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 15, 2025
Merged

Conversation

Maschga
Copy link
Collaborator

@Maschga Maschga commented Aug 6, 2025

Fix #72

❔ask for camera permission
📸 scan qr code and autofill the server form

TODO:

  • question: how should the webview of the camera look like (especially how should the user exit the camera webview)
  • question: how should a invalid qr code be handled (-> display error message in ui ?)
  • testing iPhone 15 Pro (iOS 18), Google Pixel 6a (Android 16) @naltatis
  • testing Android @Maschga

Screenshot_20250806_215301_evcc.png

@naltatis
Copy link
Member

naltatis commented Aug 6, 2025

how should a invalid qr code be handled (-> display error message in ui ?)

Good question. I'd suggest keeping it simple and only react to valid QR-codes. We can make this more sophisticated later.

how should the webview of the camera look like

Havent tested the code yet. My assumption would be a fullscreen camera view. Are there builtin close/cancel controls of the camera module we can use? Otherwise I'd suggest an "x" in the top right. Similar to the one in the "Change Server" screen. If its easier we could also do the QR code scanner / camera view embedded in a view with regular title and close controls (not fullscreen).

@naltatis naltatis added the enhancement New feature or request label Aug 6, 2025
@Maschga
Copy link
Collaborator Author

Maschga commented Aug 6, 2025

Unfortunately there aren't any predefined controls.
I first tried out your x, but then thought that it's a bit too small.
So i was interested in how a "Get Back" Button would look like.
This is the result:
Screenshot_20250806_230927_evcc.png

@Maschga
Copy link
Collaborator Author

Maschga commented Aug 6, 2025

I'll leave it up to you to decide which button it will be.

@naltatis naltatis marked this pull request as ready for review August 15, 2025 15:16
@naltatis
Copy link
Member

Successfully tested on iOS.

🔍 scanning
IMG_6973

❌ invalid qr code
IMG_6974

✅ success
IMG_6975

@naltatis
Copy link
Member

Android Test war auch erfolgreich.

@Maschga
Copy link
Collaborator Author

Maschga commented Aug 15, 2025

Funktioniert auf Android super! Großartiges Design!

@naltatis naltatis merged commit df955b4 into evcc-io:main Aug 15, 2025
2 checks passed
@Maschga Maschga deleted the feat/qr-code-scanner branch August 19, 2025 12:28
naltatis added a commit that referenced this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup via QR Code
2 participants