Delete symfony-cmf/routing dependency #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symfony-cmf/routing dependency is not necessary as it is included on ezsystems/ezpublish-kernel
|
If it is not used here we can indeed remove it, @lolautruche any input on what it was added for here? |
|
I can't remember why it was added here... Most likely for tests, but I'm not sure. Anyway it's already included in |
|
Reading ee4141a#diff-b5d0ee8c97c7abd7e3fa29b9a27d1780 it was most likely to be able to use beta |
|
True, which is no longer the case. clear. |
andrerom
approved these changes
Mar 13, 2018
adamwojs
approved these changes
Mar 13, 2018
|
Thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony-cmf/routing dependency is not necessary as it is included on ezsystems/ezpublish-kernel