Minimal postal address with line7 of AFNOR norm #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://www.rnvp-internationale.com/norme-postale/NF-Z-10-011.php, It is better to require line6 field instead line1 field
|
@jthiard @BertrandGervais have you seen this subject ? in the table documentation of postal address, the field line7 no appears whereas in the json schema it is present. Can you update the table accordingly please ? |
|
@nonow53 sorry for the late reply. Your proposal seems good. I think it could be merged without changing the overall data model meaning. It is more of a bug fix. @ghislainfabmob , what do you think of merging ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About address field type, there was a difference between the documentation and the json schema. In the JSON, the line7 is available.
Moreover, the only field required was line1 whereas the line 1 corresponds to person's names. The person's names are not mandatory to process address values.
To create an address field, I suggest to have at least the line7 field with the country. I think that the target should be the CMS account store line7/line6/line4 for a personal address. line7 (or 6 ?) is sufficient as required rules.