fix: rename bottom stack frame #33680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoxyq
force-pushed
the
rename-react-stack-bottom-frame
branch
from
a36128f to
f63d436
Compare
|
Comparing: 7216c0f...a8c869c Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
sebmarkbage
reviewed
Jul 1, 2025
sebmarkbage
approved these changes
Jul 1, 2025
hoxyq
force-pushed
the
rename-react-stack-bottom-frame
branch
from
f63d436 to
a8c869c
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
`react-stack-bottom-frame` -> `react_stack_bottom_frame`. This survives `@babel/plugin-transform-function-name`, but now frames will be displayed as `at Object.react_stack_bottom_frame (...)` in V8. Checks that were relying on exact function name match were updated to use either `.indexOf()` or `.includes()` For backwards compatibility, both React DevTools and Flight Client will look for both options. I am not so sure about the latter and if React version is locked. DiffTrain build for [91d097b](91d097b)
github-actions bot
pushed a commit
that referenced
this pull request
Jul 1, 2025
`react-stack-bottom-frame` -> `react_stack_bottom_frame`. This survives `@babel/plugin-transform-function-name`, but now frames will be displayed as `at Object.react_stack_bottom_frame (...)` in V8. Checks that were relying on exact function name match were updated to use either `.indexOf()` or `.includes()` For backwards compatibility, both React DevTools and Flight Client will look for both options. I am not so sure about the latter and if React version is locked. DiffTrain build for [91d097b](91d097b)
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jul 3, 2025
Summary: # Changelog: [Internal] Adaptation for facebook/react#33680. Reviewed By: jackpope Differential Revision: D77737710
hoxyq
added a commit
to hoxyq/react-native
that referenced
this pull request
Jul 3, 2025
Summary: # Changelog: [Internal] Adaptation for facebook/react#33680. Reviewed By: jackpope Differential Revision: D77737710
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jul 3, 2025
Summary: Pull Request resolved: #52398 # Changelog: [Internal] Adaptation for facebook/react#33680. Reviewed By: jackpope Differential Revision: D77737710 fbshipit-source-id: 6c6893935e8da8175c0cd9ceab21cc05e2092e7a
hoxyq
added a commit
that referenced
this pull request
Jul 4, 2025
Changes from 6.1.3: * feat: static Components panel layout ([hoxyq](https://github.com/hoxyq) in [#33696](#33696)) * fix: support optionality of structured stack trace function name ([hoxyq](https://github.com/hoxyq) in [#33697](#33697)) * fix: rename bottom stack frame ([hoxyq](https://github.com/hoxyq) in [#33680](#33680))
jackpope
pushed a commit
that referenced
this pull request
Jul 16, 2025
`react-stack-bottom-frame` -> `react_stack_bottom_frame`. This survives `@babel/plugin-transform-function-name`, but now frames will be displayed as `at Object.react_stack_bottom_frame (...)` in V8. Checks that were relying on exact function name match were updated to use either `.indexOf()` or `.includes()` For backwards compatibility, both React DevTools and Flight Client will look for both options. I am not so sure about the latter and if React version is locked.
jackpope
pushed a commit
that referenced
this pull request
Jul 16, 2025
`react-stack-bottom-frame` -> `react_stack_bottom_frame`. This survives `@babel/plugin-transform-function-name`, but now frames will be displayed as `at Object.react_stack_bottom_frame (...)` in V8. Checks that were relying on exact function name match were updated to use either `.indexOf()` or `.includes()` For backwards compatibility, both React DevTools and Flight Client will look for both options. I am not so sure about the latter and if React version is locked.
gaearon
added a commit
that referenced
this pull request
Jul 28, 2025
See #34021 (comment). The purpose of the changelog is to communicate to React users what changed in the release. Therefore, it is important that the changelog is written oriented towards React end users. Historically this means that we omit internal-only changes, i.e. changes that have no effect on the end user behavior. If internal changes are mentioned in the changelog (e.g. if they affect end user behavior), they should be phrased in a way that is understandable to the end user — in particular, they should not refer to internal API names or concepts. We also try to group changes according to the publicly known packages. In this PR: - Make #33680 an actual link (otherwise it isn't linkified in CHANGELOG.md on GitHub). - Remove two changelog entries listed under "React" that don't affect anyone who upgrades the "React" package, that are phrased using terminology and internal function names unfamiliar to React users, and that seem to be RN-specific changes (so should probably go into the RN changelog that goes out with the next renderer sync that includes these changes).
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This was referenced Aug 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
react-stack-bottom-frame->react_stack_bottom_frame.This survives
@babel/plugin-transform-function-name, but now frames will be displayed asat Object.react_stack_bottom_frame (...)in V8. Checks that were relying on exact function name match were updated to use either.indexOf()or.includes()For backwards compatibility, both React DevTools and Flight Client will look for both options. I am not so sure about the latter and if React version is locked.