-
Notifications
You must be signed in to change notification settings - Fork 98
Support maps automation #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks quite powerful, but is there any way we could make it work in more 'human' terms instead of pixels?
src/main/java/nl/hsac/fitnesse/fixture/util/selenium/SeleniumHelper.java
Outdated
Show resolved
Hide resolved
wiki/FitNesseRoot/HsacExamples/SlimTests/BrowserTests/WorkWithMaps.wiki
Outdated
Show resolved
Hide resolved
wiki/FitNesseRoot/HsacExamples/SlimTests/BrowserTests/WorkWithMaps.wiki
Outdated
Show resolved
Hide resolved
Hi, @fhoeben , |
Hello, @fhoeben , I'm not making lots of PR's. Not sure if i'm missing something, that should be done by me, or should i just wait? :D Thank you, |
At this time I don't think I'm waiting on something from you. I just haven't gotten around to looking at your latest changes. Sorry. Can you wait a bit longer? |
Sure, |
src/main/java/nl/hsac/fitnesse/fixture/slim/web/BrowserTest.java
Outdated
Show resolved
Hide resolved
src/main/java/nl/hsac/fitnesse/fixture/util/selenium/SeleniumHelper.java
Outdated
Show resolved
Hide resolved
src/main/java/nl/hsac/fitnesse/fixture/util/selenium/SeleniumHelper.java
Outdated
Show resolved
Hide resolved
wiki/FitNesseRoot/HsacAcceptanceTests/SlimTests/BrowserTest/DoubleClickAtXoffsetAndYoffset.wiki
Outdated
Show resolved
Hide resolved
wiki/FitNesseRoot/HsacAcceptanceTests/SlimTests/BrowserTest/RightClickAtXoffsetAndYoffset.wiki
Outdated
Show resolved
Hide resolved
Thank you for detailed review @fhoeben , and my apologies for mistakes i left (after pinging you so hard:) ) Hope this one aa6590d Hope to hear you soon and have a good day ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes done with commit aa6590d
For me the test needed a small update. url after zooming is always: https://www.google.com/maps/@51.7147561,11.342505,5.16z |
Hello, @fhoeben With chromedriver i tried with: There's slight delay for it to change. Thats why i left hardcoded 800 milliseconds 'wait' before checking location. Perhaps on slower environments this 800 is not enough... I will think of something |
There are 2 options for this issue on public google maps:
Which one you prefer? |
One more idea - i could make example with mock up if you prefer ;) |
I don't believe it's a timing issue. Even if I wait 10s (chrome on macOS, fiber internet) the location does not change. |
PR inclues: