Skip to content

Check plugins compatibility when upgrading to v4 #17280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Aug 18, 2025

Conversation

CharlieEtienne
Copy link
Contributor

This PR introduces a new artisan command that will check installed plugins compatibility with Filament v4.

php artisan filament:check-plugins-compatibility-with-v4

Should print a table like this in the console:

image

@CharlieEtienne CharlieEtienne marked this pull request as draft August 12, 2025 20:20
@CharlieEtienne
Copy link
Contributor Author

As suggested by @danharrin on Discord, I updated the upgrade script to include this check.

It checks for incompatible plugins and exit upgrade script if any incompatible package is found:

Capture d’écran 2025-08-13 à 02 13 48

If all packages are compatible, it continues the upgrade normally:

Capture d’écran 2025-08-13 à 02 40 17

@CharlieEtienne CharlieEtienne marked this pull request as ready for review August 13, 2025 00:48
@danharrin danharrin added the enhancement New feature or request label Aug 13, 2025
@danharrin danharrin added this to the v4 milestone Aug 13, 2025
@CharlieEtienne
Copy link
Contributor Author

Let me know if you want to keep the separate command, or just the script.

Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the separate command as you mentioned

@github-project-automation github-project-automation bot moved this from Todo to In Progress in Roadmap Aug 14, 2025
@CharlieEtienne
Copy link
Contributor Author

Please remove the separate command as you mentioned

Done in f82ab72

@CharlieEtienne CharlieEtienne changed the title Add a command that checks plugins compatibility with v4 Check plugins compatibility when upgrading to v4 Aug 14, 2025
@danharrin
Copy link
Member

Thanks, I added a few more experimental things to see what people think. I don't think the Tailwind command I added is ready to be added to the docs yet, but it would be good if people could test it. It freezes for me when I run it on the Filament demo for some reason.

@danharrin danharrin merged commit 4cf7519 into filamentphp:4.x Aug 18, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Roadmap Aug 18, 2025
@CharlieEtienne
Copy link
Contributor Author

That's good addition! I'll try to test it soon

@urufudev
Copy link
Contributor

Hi, will this command also be available in Filament v3?
I think many users who are still on version 3 would like to check plugin compatibility before deciding to upgrade to v4.

@danharrin
Copy link
Member

The v4 upgrade scripts runs in Filament 3.

@archilex
Copy link
Contributor

@CharlieEtienne Hi! This script seems to fail with private/paid plugins as they aren't accessible through packgist. Any way this could be updated to either skip paid plugins or allow the dev to whitelist them in some sort of config?

@danharrin
Copy link
Member

@archilex is an exception thrown? If there is an error, it should just be skipped in the entire checking process.

@archilex
Copy link
Contributor

No...no exception is thrown. $json = @file_get_contents($url); returns false so it just gets thrown into the $incompatiblePlugins array

@danharrin
Copy link
Member

Maybe the @ should be removed? I think that silences the exception

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants