-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Check plugins compatibility when upgrading to v4 #17280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
packages/upgrade/src/Commands/CheckPluginsCompatibilityWithV4.php
Outdated
Show resolved
Hide resolved
…ad of HTTP requests as suggested by Saade
As suggested by @danharrin on Discord, I updated the upgrade script to include this check. It checks for incompatible plugins and exit upgrade script if any incompatible package is found: ![]() If all packages are compatible, it continues the upgrade normally: ![]() |
Let me know if you want to keep the separate command, or just the script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the separate command as you mentioned
Done in f82ab72 |
Thanks, I added a few more experimental things to see what people think. I don't think the Tailwind command I added is ready to be added to the docs yet, but it would be good if people could test it. It freezes for me when I run it on the Filament demo for some reason. |
That's good addition! I'll try to test it soon |
Hi, will this command also be available in Filament v3? |
The v4 upgrade scripts runs in Filament 3. |
@CharlieEtienne Hi! This script seems to fail with private/paid plugins as they aren't accessible through packgist. Any way this could be updated to either skip paid plugins or allow the dev to whitelist them in some sort of config? |
@archilex is an exception thrown? If there is an error, it should just be skipped in the entire checking process. |
No...no exception is thrown. |
Maybe the |
This PR introduces a new artisan command that will check installed plugins compatibility with Filament v4.
Should print a table like this in the console: