[FDC] Simplify init flow for Spark projects

[fredzqm]

For newly created project

Old behavior: Enable a few APIs (take a while), then write the free trial template.

New behavior: If FDC API wasn't enabled, just write the template and exist.

[gemini-code-assist]

Summary of Changes

Hello @fredzqm, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the initialization process for Spark projects by optimizing the API enablement flow. Instead of unconditionally enabling several APIs, the system now first checks if the core Data Connect API is already enabled. If it is, it proceeds with ensuring other necessary APIs and prompting for existing services; otherwise, it simplifies the initial setup by only writing the template, reducing setup time for new projects where the API might not yet be active.

Highlights

• Optimized API Initialization: The ensureApis function now conditionally checks if the Data Connect API is already enabled using a new isApiEnabled function, preventing redundant API enablement calls during project initialization.
• Reduced API Dependencies: The computeOrigin API is no longer ensured as part of the general ensureApis flow, simplifying the required API set for Data Connect projects.
• Refactored Setup Logic: The askQuestions function in the Data Connect initialization feature has been updated to incorporate the new conditional API checks, leading to a more efficient and responsive setup experience.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request simplifies the init flow for Spark projects by checking for API enablement upfront. If APIs are not enabled, it triggers the enablement process in the background to improve the user experience, which is a great enhancement. My main feedback is to add error handling for this background task to prevent unhandled promise rejections that could crash the application.

[gemini-code-assist]

Using void to fire-and-forget this promise is a good way to speed up the init flow. However, if the ensureApis promise rejects (for example, due to permissions or billing issues), it will result in an unhandled promise rejection, which can crash the Node.js process.

It's safer to attach a .catch() handler to log the error for debugging purposes without blocking the main execution thread.

      ensureApis(setup.projectId).catch((err) => {
        // Log for debugging, but don't block the init flow.
        logger.debug(`[dataconnect] Background API enablement failed: ${err.message}`);
      });