Fix a crash on startup when ulimits are set to unlimited.

[cassandras-lies]

PR intention

Fix a crash on startup.

Code changes brief

If ulimit is set to unlimited, getrlimit will return a value of UINT_MAX, but it was being interpreted as an int, so this was evaluated as -1 and led to a crash on startup thinking resource limits had been hit.

[coderabbitai]

Walkthrough

The update changes the types of three internal initialization variables from int to rlim_t in the src/init.cpp file. All related logic and calculations in the AppInitParameterInteraction() function are updated to use rlim_t, ensuring type consistency for resource limit operations.

Changes

File(s)	Change Summary
src/init.cpp	Changed variable types (nMaxConnections, nUserMaxConnections, nFD) from int to rlim_t; updated related logic in AppInitParameterInteraction() to use rlim_t and appropriate casts for resource limit calculations.

Poem

Three variables grew up today,
From humble int to rlim_t they say.
Now limits are clear, resource bounds tight,
With type-safe math, all through the night.
The code hops forward, strong and neat—
A rabbit’s work is now complete! 🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 91a9fb5 and a2e2da3.

📒 Files selected for processing (1)

• src/init.cpp (4 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• src/init.cpp

⏰ Context from checks skipped due to timeout of 90000ms (6)

• GitHub Check: Build for Linux (Autotools)
• GitHub Check: Build for Windows (Autotools)
• GitHub Check: Build for macOS (Autotools)
• GitHub Check: Build for Linux (CMake)
• GitHub Check: Build for macOS (CMake)
• GitHub Check: Build for Windows (CMake)

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[aleflm]

Looks good to me.

Just a suggestion, how about using uint64_t instead of introducing rlim_t.

[cassandras-lies]

The return parameter is defined to be rlim_t, which is not necessarily uint64_t, it could be an int or something depending on the platform. I defined it as an unsigned long long on Windows in the #else directive.