fix(setup): auto-detect Ubuntu 26.04 and set PLAYWRIGHT_HOST_PLATFORM_OVERRIDE#2113
Open
padmarajnidagundi wants to merge 1 commit into
Open
Conversation
…_OVERRIDE Playwright does not yet ship a native chromium build for ubuntu26.04-x64. When setup detects Ubuntu 26.04, it now automatically sets PLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04-x64 before calling bunx playwright install chromium. The ubuntu24.04 binary runs fine on ubuntu26.04 (same glibc lineage). Without this fix users see: Failed to install browsers Error: ERROR: Playwright does not support chromium on ubuntu26.04-x64 The override is scoped to the install subshell; it does not persist to the environment or affect subsequent setup steps. Fixes garrytan#2101
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Author
|
/trunk merge |
|
An error occurred while submitting your PR to the queue: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2101
Playwright does not yet ship a native chromium build for ubuntu26.04-x64. Running ./setup on Ubuntu 26.04 fails immediately with:
\
Failed to install browsers
Error: ERROR: Playwright does not support chromium on ubuntu26.04-x64
\\
Fix
The setup script now reads /etc/os-release before calling �unx playwright install chromium. When it detects Ubuntu 26.04, it sets PLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04-x64 for the install subshell only. The ubuntu24.04 binary runs correctly on ubuntu26.04 (same glibc lineage).
The override is scoped to the subshell — it does not persist to the caller's environment or affect any other setup step.
The workaround documented in #2101 (PLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04-x64 ./setup) still works for users on other unsupported future Ubuntu versions.
Testing