-
-
Notifications
You must be signed in to change notification settings - Fork 0
Add support for website submissions and enhance metadata handling #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for website submissions and enhances metadata handling by implementing a new metadata submission interface, improving access controls for different object types, and optimizing background processes. The changes focus on enabling users to submit metadata corrections and introducing new data sources.
Key changes include:
- Added new metadata submission functionality for website-based corrections
- Enhanced role-based access controls for different data object types
- Introduced support for Boolean attributes and RetroAchievements metadata source
- Optimized background task scheduling and vote tallying processes
Reviewed Changes
Copilot reviewed 27 out of 28 changed files in this pull request and generated 6 comments.
Show a summary per file
File | Description |
---|---|
hasheous/wwwroot/scripts/dataobjects.js | Added Boolean attribute support for form inputs |
hasheous/wwwroot/pages/status.js | Added RetroAchievements metadata service and admin task controls |
hasheous/wwwroot/pages/dataobjectmatchsubmit.js | New metadata submission interface implementation |
hasheous/wwwroot/pages/dataobjectdetail.js | Enhanced metadata filtering and submission button |
hasheous/Classes/Submissions.cs | Expanded vote validation and optimized processing |
hasheous/Controllers/V1.0/DataObjectController.cs | Added public app visibility and enhanced permissions |
Comments suppressed due to low confidence (1)
hasheous/Classes/Submissions.cs:99
- The variable name 'url' is reused multiple times in the switch statement, making the code confusing. Consider using more specific names like 'epicUrl', 'steamUrl', etc.
string url = metadataMatch.GameId;
Implement support for website submissions, update the metadata search to perform a force scan, and optimize data processing by focusing on items with votes. Additionally, ensure consistent artwork fetching and introduce new metadata sources.